Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: make nicer report message for run-example command #642

Merged
merged 1 commit into from May 25, 2022

Conversation

VMois
Copy link

@VMois VMois commented May 19, 2022

closes #641

@codecov-commenter
Copy link

Codecov Report

Merging #642 (7ded734) into master (a8a94a1) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #642      +/-   ##
==========================================
- Coverage   18.88%   18.84%   -0.04%     
==========================================
  Files          26       26              
  Lines        2134     2138       +4     
==========================================
  Hits          403      403              
- Misses       1731     1735       +4     
Impacted Files Coverage Δ
reana/reana_dev/run.py 26.63% <0.00%> (-0.48%) ⬇️

@mdonadoni mdonadoni self-requested a review May 23, 2022 14:42
Copy link
Member

@mdonadoni mdonadoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only one minor comment to address

Comment on lines 626 to 627
def _format_report(workflows) -> str:
return f": {', '.join(workflows)}" if workflows else ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(minor) What do you think about using _format_report when printing the test matrix? That way, if we want to modify the format in the future, we only have to change the code in one place for both the test matrix and the test results.

f" - {len(components)} demo example(s): {', '.join(components)}\n"
f" - {len(workflow_engines)} workflow engine(s): {', '.join(workflow_engines)}\n"
f" - {len(compute_backends)} compute backend(s): {', '.join(compute_backends)}"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did. Although, _format_report was only created to keep : or not depending on the list size. So not sure how much it will benefit in _test_matrix. But why not.

@audrium audrium merged commit 13c01ae into reanahub:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run-example --check-only
4 participants