fix(reana-dev): update container image labels when releasing (#765)

[tiborsimko]

Changes reana-dev git-create-release-commit behaviour to also update the container image label version when releasing cluster components.

[codecov]

Codecov Report

Attention: Patch coverage is 11.76471% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 18.54%. Comparing base (c533c34) to head (fe6bc2c).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #765      +/-   ##
==========================================
- Coverage   18.56%   18.54%   -0.02%     
==========================================
  Files          26       26              
  Lines        2359     2372      +13     
==========================================
+ Hits          438      440       +2     
- Misses       1921     1932      +11     

Files	Coverage Δ
reana/config.py	100.00% <100.00%> (ø)
reana/reana_dev/git.py	29.00% <0.00%> (-0.13%)	⬇️
reana/reana_dev/utils.py	35.52% <7.69%> (-0.62%)	⬇️

[mdonadoni]

Looks good! Just one small discussion point

[mdonadoni]

How do we want to update the date in the Dockerfile, also considering that we are switching to release-please?

[tiborsimko]

I guess we'd have to update it ourselves at the day we are releasing and compiling the user-facing summary to be put into CHANGELOG before the regular news items generated by Release Please.

Might be nice to script it further, we would probably need to read upstream/release-please--branches--master branch content, enrich it and push back. Perhaps a job for a new command?

[mdonadoni]

But the user-facing summary would only be for the general reana repository, wouldn't it? I would avoid having an user-facing summary for each component, as I think that 1) that would not be very useful to the users in any case 2) it would cancel the benefit of using conventional commits and release-please by introducing a manual step in what could otherwise be a fully automatic release.

Regarding the second point, if we want to script it then I guess we could remove the label from the Dockerfile itself, and then set it from the CLI when building the image (either with reana-dev or with our custom GitHub action). In this way we would not need a new command, and we could still use release-please PRs without having to modify them.

What do you think?

[tiborsimko]

WRT user-facing summaries, fully agree about doing it only for the user-facing repositories, such as reana and perhaps some like reana-client, reana-client-go. We may not even need them for every patchlevel release, only for "big" releases (major, and perhaps minor).

WRT updating also date, (a) I could amend git-create-release-commit command to do this too; (b) removing this label from Dockerfile could also be interesting at a slight con of not having full labels in the source code repository; (c) BTW we also do need to be aware of updating the date in the Release Please's made pull request, if the release is not happening the same day. We can see IRL about pros/cons?