Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: reaper.CF_GetTrackFXChain(track) #1222

Closed
Edgemeal opened this issue Nov 15, 2019 · 2 comments
Closed

BUG: reaper.CF_GetTrackFXChain(track) #1222

Edgemeal opened this issue Nov 15, 2019 · 2 comments
Assignees
@cfillion
Labels
bug

Comments

@Edgemeal
Copy link

reaper.CF_GetTrackFXChain(track) doesn't work if track has a name.

https://forum.cockos.com/showthread.php?t=227119
@cfillion cfillion self-assigned this Nov 15, 2019
@cfillion cfillion added the bug label Nov 15, 2019
cfillion added a commit to cfillion/sws that referenced this issue Nov 15, 2019
@cfillion
fix CF_GetTrackFXChain with named tracks
f6a295c 
Fixes reaper-oss#1222
@cfillion
Copy link
Member

cfillion commented Nov 15, 2019 •
edited
Loading

Oops! Fixed in this build: https://ci.appveyor.com/api/buildjobs/2r6af2hc97rkoag1/artifacts/build%2Fsws-2.11.0.0-Windows-x64-d08c167c.exe.

cfillion added a commit to cfillion/sws that referenced this issue Nov 15, 2019
@cfillion
fix CF_GetTrackFXChain with named tracks
d16f46a 
Fixes reaper-oss#1222
@cfillion
Copy link
Member

cfillion commented Nov 17, 2019 •
edited
Loading

Here's a better fix that ensures CF_GetTrackFXChain returns the correct FX chain even if two tracks with opened FX chains across multiple projects share the same number + name: https://ci.appveyor.com/api/buildjobs/kipb8xbr8t20xyps/artifacts/build%2Fsws-2.11.0.0-Windows-x64-40db15fc.exe.

cfillion added a commit that referenced this issue Nov 19, 2019
@cfillion
Merge pull request #1223 from cfillion/fix-cf_gettrackfxchain-named-t…
0931553 
…racks

Fix CF_GetTrackFXChain with named tracks  (Issue #1222) and disambiguate FX chains across all opened projects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cfillion cfillion

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cfillion @Edgemeal