Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWS 2.9.6 Bug - Region Playlist skips regions #886

Closed
GassnKlang opened this issue Sep 6, 2017 · 5 comments
Closed

SWS 2.9.6 Bug - Region Playlist skips regions #886

GassnKlang opened this issue Sep 6, 2017 · 5 comments

Comments

@GassnKlang
Copy link

@GassnKlang GassnKlang commented Sep 6, 2017

Hey!
there is a bug in SWS Region Playlist:

https://www.dropbox.com/s/o51ddolwx4mat83/test.rpp?dl=0

In this Demo-Project there is a bunch of regions. Open region playlist and hit the "play" button (not the transport play but the play button within "playlist"). Wait till the cursor leaves region 1. If it goes straight to region 2, everything is fine (it's setup this way). About every second to third time the curser jumps directly to region 3 and skips region 2. Is there a fast way to fix this? My live setup is depending on this. Thanks!

I'm on Windows 10 using REAPER 5.62 64bit and SWS 2.9.6

Edit: It seems like if you shorten the regions by a few ms, the bug disappears.

@GassnKlang
Copy link
Author

@GassnKlang GassnKlang commented Nov 13, 2017

still up to date...
the dropbox link was broken, I uploaded the project once again and updated the link in the first post.

@nofishonfriday
Copy link
Collaborator

@nofishonfriday nofishonfriday commented Nov 22, 2017

Confirmed with your test project, thanks.
As you say, the skipping doesn't happen every time here but (mostly) only every third time or so.

I may have a potential fix (actually currently rather a blind shot), you can test if you want.
https://www.dropbox.com/s/6hojsyi7gymbxkw/reaper_sws64_RegionPlaylistTest.dll?dl=1

I've run the region playlist from your test project in loop for some time with this change and couldn't observe any skipping.
I'm currently unclear though what potential side effects this change may have on the Region Playlist (I don't use it myself) so please report if you find any anomalies.

@ the other SWS collaborators:
I've pushed the change to my SWS fork (see above) and I'd appreciate thoughts / help on this. :)

@cfillion
Copy link
Collaborator

@cfillion cfillion commented Feb 6, 2021

Closing as #940 fixed this.

@cfillion cfillion closed this Feb 6, 2021
@nofishonfriday
Copy link
Collaborator

@nofishonfriday nofishonfriday commented Feb 6, 2021

Out of curiousity: Did you test it or can you confirm from the code it's (fully) fixed?
Tbh I wasn't totally sure what I was doing in that fix and it was more of a trial & error thing.

@cfillion
Copy link
Collaborator

@cfillion cfillion commented Feb 6, 2021

I didn't double check; The fix seems reasonable, there hasn't been reports of the issue in the 3 years since (and I vaguely recall trying it back then).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants