Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyze loudness window UI bugs #942

Closed
mkruselj opened this issue Jan 16, 2018 · 5 comments
Closed

Analyze loudness window UI bugs #942

mkruselj opened this issue Jan 16, 2018 · 5 comments

Comments

@mkruselj
Copy link

  1. Right-clicking the column header, checkboxes are not shown for the enabled columns

  2. Sorting by True peak column is broken. Positive dBTP values are sorted AFTER the lowest negative value! This is clearly wrong, should be an easy fix?
@cfillion
Copy link
Member

  1. It works here. https://i.imgur.com/YaFTG6Y.png
  2. Try this build: https://cfillion.ca/files/sws/numeric-truepeak-sort/

@mkruselj
Copy link
Author

That build fixes the sorting, but not the checkboxes. Not sure what's up with that... (W10 here, latest Reaper pre).

cfillion added a commit to cfillion/sws that referenced this issue Jan 16, 2018
@cfillion
Loudness: sort the true peak column by the number value [reaper-oss#942]
6aafbf3 
It was previously sorted lexicographically.

Fixes reaper-oss#942
@cfillion
Copy link
Member

What is the value of BR - AnalyzeLoudnessView WndPos in your reaper.ini? Are the checkboxes still broken for you in a fresh portable install?

@mkruselj
Copy link
Author

BR - AnalyzeLoudness=0 1 1 1 0 1 1 1 0
BR - AnalyzeLoudnessView WndPos=-6 25 0 265 1 216 2 87 3 70 4 70 5 115 6 115 7
BR - AnalyzeLoudness WndPos=3B0200007A0100001B07000086030000000000000000000063
BR - AnalyzeLoudness WndPos=0.50000000 0

But even if I remove all that from the .ini, still no checkboxes. There's only one grayed out under "visible columns"...

image

cfillion added a commit to cfillion/sws that referenced this issue Jan 17, 2018
@cfillion
ListView: fix column header context menu when a langpack is used [rea…
ab365e8 
…per-oss#942]

SWS automatically sorts context menus if a langpack is loaded. This
breaks the column header context menu. This patch ensure the column
header context menu is never sorted.

Fixes reaper-oss#942.
@mkruselj
Copy link
Author

mkruselj commented Apr 1, 2018

This was fixed in PR #942.

@mkruselj mkruselj closed this as completed Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkruselj @cfillion