New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: Post Take/Item properties item loudness ReaScript Functions #957
Comments
@X-Raym If yes, seems there may be a bug and nothing I can do about regarding this request. |
@nofishonfriday Here is what I get from SWS/BR; Analyse Loudness... with two analyses of the same item (first with volume envelope at 0, then volume envelope -10dB).
As you can see, it seems that it works as expected. Envelope_Evaluate() is working fine with other scripts of mine. You can try with Script: X-Raym_Copy envelope values at edit cursor and insert at time selection.lua |
@nofishonfriday which SWS do you use ? I use the official v2.9.8.0. Ok I notice something weird. It does seems to works post env and post fades.... But only if item pos is 0. Can you confirm ? |
Interesting find ! Thanks. |
@nofishonfriday That would be a dirty solution though. |
Haha good one. |
@nofishonfriday |
Seems I found the issue: Actually a Reaper bug I'd think, created a BR: Let's see what comes out of it, could maybe also worked around it in SWS if it doesn't get fixed (or not classified as bug). edit: |
May have it fixed, please test: I couldn't make it fail so far with complex take vol. env's also if item pos not 0.0. |
@nofishonfriday Nice ! truePeakPos, shortTermMaxPos, momentaryMaxPos doesn't seems to be consistent (some are relative, some are absolute). (also, NF_GetMediaItemMaxPeakAndMaxPos() is absolute now ?) |
You're right, currently TPpos: relative, shortTermMaxPos, momentaryMaxPos: absolute. NF_GetMediaItemMaxPeakAndMaxPos() should still be realtive though, it's here at least, could you recheck pls ? Btw., the bug was quite hard to find (for me anyway), the crucial key was your observation working correctly if item pos = 0.0, so thanks for this again. :) |
@nofishonfriday Oh sorry for NF_GetMediaItemMaxPeakAndMaxPos() , my bad, it do works as expected. Ok for not breaking compatibility with previous scripts and for update in the doc. but maybe in this case TPpos should be absolute too ? At least it would be consistent within this function. |
I follow the thought but it would be the same problem with potentially breaking existing scripts as it's been relative from the beginning (as you stated) so I think I'd rather leave it like this and try to do better next time. :) |
@nofishonfriday backward compatibility is more important that consitency. And it is not as if the fix was hard to fix on the script side :P At least the post fades and envelopes is fixed now :P The pull request can be proposed and the issue closed. |
Pull request coming shortly... :) |
@nofishonfriday You are right.
I think I'm starting to be confused by all these subtleties :P It definitely deserves to be in the doc for clarity. (that said, GetMediaItemMaxPeakAndMaxPeakPos being post fades, it may be possible at some point to make a Loudness function which take cares of fades. But maybe another day... 😸 ) |
Thanks for confirming. I've now linked to the Signal flow chart for the ReaScript Loudness functions so it should make it clear. |
- Revert (mistakenly) changing integrated Loudness relative gate threshold from -10.0 LU to -20.0 LU in SWS v2.9.8 - Fix getting project sample rate - Don't apply item vol. and pan/vol. envelope correction beyond actual audio data (fixes reaper-oss#1074) - Fix item Loudness analysis if take contains volume envelope (closes reaper-oss#957)
- Revert (mistakenly) changing integrated Loudness relative gate threshold from -10.0 LU to -20.0 LU in SWS v2.9.8 - Fix getting project sample rate - Don't apply item vol. and pan/vol. envelope correction beyond actual audio data (fixes reaper-oss#1074) - Fix item Loudness analysis if take contains volume envelope and item pos. not 0.0 (closes reaper-oss#957)
Hi,
the current Loudness ReaScript functions return loudness pre-fades and pre volume envelopes.
It would be nice if it could returns loudness after all take properties (fades, gain, volumes etc...)
As shown on the Loudness signal flow there:
http://wiki.cockos.com/wiki/index.php/Measure_and_normalize_loudness_with_SWS
This was originally discussed on this issue:
#953 (comment)
Thanks for listening !
The text was updated successfully, but these errors were encountered: