fix: #596 condition to check completed status (#672)

* fix: condition to check completed status (#596)

* chore:  #596 add more test cases

Co-authored-by: Duong Pham <duongph@reapit.com>

packages/elements/src/utils/completed-section/__tests__/completed-sections.ts

@@ -9,7 +9,7 @@ import {
 
 describe('completed-sections', () => {
   describe('isCompletedProfile', () => {
-    it('should run correctly', () => {
+    it('should return true', () => {
       const params = {
         title: 'Mr',
         surname: 'A',
@@ -24,18 +24,52 @@ describe('completed-sections', () => {
       expect(result).toBeTruthy()
     })
 
-    it('should run correctly', () => {
+    it('should return false', () => {
+      const params = {
+        title: 'Mr',
+        surname: 'A',
+        forename: 'B',
+        dateOfBirth: '04/04/1996',
+        email: 'tanphamhaiduong@gmail.com',
+      }
+      const result = isCompletedProfile(params)
+      expect(result).toBeFalsy()
+    })
+
+    it('should return true', () => {
       const params = {
         title: 'Mr',
         surname: 'A',
         forename: 'B',
         dateOfBirth: '04/04/1996',
         homePhone: '0123456789',
+      }
+      const result = isCompletedProfile(params)
+      expect(result).toBeTruthy()
+    })
+
+    it('should return true', () => {
+      const params = {
+        title: 'Mr',
+        surname: 'A',
+        forename: 'B',
+        dateOfBirth: '04/04/1996',
         workPhone: '0123456789',
+      }
+      const result = isCompletedProfile(params)
+      expect(result).toBeTruthy()
+    })
+
+    it('should return true', () => {
+      const params = {
+        title: 'Mr',
+        surname: 'A',
+        forename: 'B',
+        dateOfBirth: '04/04/1996',
         mobilePhone: '0123456789',
       }
       const result = isCompletedProfile(params)
-      expect(result).toBeFalsy()
+      expect(result).toBeTruthy()
     })
 
     it('should run correctly', () => {

packages/elements/src/utils/completed-section/completed-sections.ts

@@ -6,10 +6,7 @@ export const isCompletedProfile = (contact?: ContactModel | null) => {
     contact?.surname &&
     contact?.forename &&
     contact?.dateOfBirth &&
-    contact?.homePhone &&
-    contact?.workPhone &&
-    contact?.mobilePhone &&
-    contact?.email
+    (contact?.homePhone || contact?.workPhone || contact?.mobilePhone)
   return !!isValidProfile
 }
 
@@ -33,32 +30,14 @@ export const isCompletedSecondaryID = (identityCheck?: IdentityCheckModel | null
 
 export const isCompletedAddress = (contact?: ContactModel | null) => {
   const isValidPrimaryAddress =
-    !!contact?.primaryAddress?.buildingName &&
-    !!contact?.primaryAddress?.buildingNumber &&
     !!contact?.primaryAddress?.line1 &&
-    !!contact?.primaryAddress?.line2 &&
     !!contact?.primaryAddress?.line3 &&
-    !!contact?.primaryAddress?.line4 &&
+    !!contact?.primaryAddress?.postcode &&
     !!contact?.metadata?.primaryAddress?.year &&
     !!contact?.metadata?.primaryAddress?.month &&
     !!contact?.metadata?.primaryAddress?.documentType &&
     !!contact?.metadata?.primaryAddress?.documentImage
-  const isValidSecondaryAddress =
-    !!contact?.secondaryAddress?.buildingName &&
-    !!contact?.secondaryAddress?.buildingNumber &&
-    !!contact?.secondaryAddress?.line1 &&
-    !!contact?.secondaryAddress?.line2 &&
-    !!contact?.secondaryAddress?.line3 &&
-    !!contact?.secondaryAddress?.line4 &&
-    !!contact?.metadata?.secondaryAddress?.year &&
-    !!contact?.metadata?.secondaryAddress?.month &&
-    !!contact?.metadata?.secondaryAddress?.documentType &&
-    !!contact?.metadata?.secondaryAddress?.documentImage
-
-  if (contact?.primaryAddress && !contact?.secondaryAddress) {
-    return !!isValidPrimaryAddress
-  }
-  return !!isValidPrimaryAddress && !!isValidSecondaryAddress
+  return !!isValidPrimaryAddress
 }
 
 export const isCompletedDeclarationRisk = (contact: ContactModel | null) => {