Skip to content

Commit

Permalink
Merge pull request #1981 from jsmeix/reorder_final_build_stage_script…
Browse files Browse the repository at this point in the history
…s_related_to_pull_request_1971

Rearranged final build stage scripts so that now
"fix_broken_links" is run before "verify_rootfs".
  • Loading branch information
jsmeix committed Nov 28, 2018
2 parents 215c9c6 + d0ce8a5 commit eb63155
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion usr/sbin/rear
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ if test "$WORKFLOW" != "help" ; then
fi

# In DEBUG mode keep by default the build area but that can be overridden in user config files
# therefore no readonly KEEP_BUILD_DIR (it is also set to 1 in build/default/980_verify_rootfs.sh):
# therefore no readonly KEEP_BUILD_DIR (it is also set to 1 in build/default/990_verify_rootfs.sh):
test "$DEBUG" && KEEP_BUILD_DIR=1 || true

# Check if we are in recovery mode:
Expand Down
2 changes: 1 addition & 1 deletion usr/share/rear/build/default/985_fix_broken_links.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# and https://github.com/rear/rear/pull/1734

# FIXME: The following code fails if symlinks or their targets contain characters from IFS (e.g. blanks),
# cf. the same kind of comments in build/default/980_verify_rootfs.sh
# cf. the same kind of comments in build/default/990_verify_rootfs.sh
# and layout/prepare/GNU/Linux/130_include_mount_subvolumes_code.sh
# see https://github.com/rear/rear/pull/1514#discussion_r141031975
# and for the general issue see https://github.com/rear/rear/issues/1372
Expand Down
2 changes: 1 addition & 1 deletion usr/share/rear/conf/default.conf
Original file line number Diff line number Diff line change
Expand Up @@ -1315,7 +1315,7 @@ SSH_UNPROTECTED_PRIVATE_KEYS='no'
# By default it is fatal when 'ldd' reports a 'not found' library for
# any file in a /bin/ or /sbin/ directory in the recovery system and
# "rear mkrescue/mkbackup" aborts with "recovery system not usable".
# For details see the build/default/980_verify_rootfs.sh script.
# For details see the build/default/990_verify_rootfs.sh script.
NON_FATAL_BINARIES_WITH_MISSING_LIBRARY=''

##
Expand Down
2 changes: 1 addition & 1 deletion usr/share/rear/lib/sesam-functions.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ if ! test -r $sesam2000ini_file ; then
return 0
fi

# for later use in default/980_verify_rootfs.sh to avoid issues
# for later use in build/default/990_verify_rootfs.sh to avoid issues
# with missing library dependencies during rootfs check
source $sesam2000ini_file
SESAM_LD_LIBRARY_PATH=$SM_BIN_SESAM
Expand Down

0 comments on commit eb63155

Please sign in to comment.