Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some workflows do not work with '-s' (validate, shell, and format) #1098

Closed
jsmeix opened this issue Dec 2, 2016 · 3 comments
Closed

Some workflows do not work with '-s' (validate, shell, and format) #1098

jsmeix opened this issue Dec 2, 2016 · 3 comments
Assignees
@jsmeix
Labels
fixed / solved / done minor bug An alternative or workaround exists
Milestone
Rear v2.00

Comments

@jsmeix
Copy link
Member

jsmeix commented Dec 2, 2016

The workflows 'validate' and 'shell' do not work correctly
when rear is called with the '-s' option

# find usr/share/rear/ | grep -- '-workflow.sh'
usr/share/rear/lib/format-workflow.sh
usr/share/rear/lib/checklayout-workflow.sh
usr/share/rear/lib/recover-workflow.sh
usr/share/rear/lib/validate-workflow.sh
usr/share/rear/lib/dump-workflow.sh
usr/share/rear/lib/shell-workflow.sh
usr/share/rear/lib/udev-workflow.sh
usr/share/rear/lib/finalizeonly-workflow.sh
usr/share/rear/lib/mkrescue-workflow.sh
usr/share/rear/lib/restoreonly-workflow.sh
usr/share/rear/lib/layoutonly-workflow.sh
usr/share/rear/lib/mkbackuponly-workflow.sh
usr/share/rear/lib/help-workflow.sh
usr/share/rear/lib/mkbackup-workflow.sh
usr/share/rear/lib/savelayout-workflow.sh

# for w in format checklayout recover validate \
 dump shell udev finalizeonly mkrescue restoreonly \
 layoutonly mkbackuponly help mkbackup savelayout ; \
 do echo $w ; usr/sbin/rear -s $w ; done

hangs up for 'validate' and 'shell'.
@jsmeix jsmeix added the minor bug An alternative or workaround exists label Dec 2, 2016
@jsmeix jsmeix added this to the Rear v2.00 milestone Dec 2, 2016
@jsmeix jsmeix self-assigned this Dec 2, 2016
@jsmeix jsmeix mentioned this issue Dec 14, 2016
Merged
jsmeix added a commit that referenced this issue Dec 14, 2016
@jsmeix
Merge pull request #1127 from jsmeix/implement_simulation_mode_for_va…
585063e 
…lidate_and_shell_workflows_issue1098

Implement simulation mode for validate and shell workflows
see #1098
@jsmeix
Copy link
Member Author

jsmeix commented Dec 14, 2016

Fixed via
#1127

@jsmeix jsmeix closed this as completed Dec 14, 2016
@jsmeix jsmeix changed the title Some workflows do not work with '-s' ('validate' and 'shell') Some workflows do not work with '-s' (validate, shell, and format) Dec 23, 2016
@jsmeix
Copy link
Member Author

jsmeix commented Dec 23, 2016

Also the format workflow does not work with plain '-s':

f79:~/rear # usr/sbin/rear -s format
Relax-and-Recover 1.19 / Git
Using log file: /root/rear/var/log/rear/rear-f79.log
Simulation mode activated, Relax-and-Recover base directory: /root/rear/usr/share/rear
Source conf/Linux-i386.conf
Source conf/GNU/Linux.conf
822: Source init/default/010_set_drlm_env.sh
822: Source init/default/030_update_recovery_system.sh
822: Source init/default/050_check_rear-recover_mode.sh
822: ERROR: No device provided as argument.
Aborting due to an error, check /root/rear/var/log/rear/rear-f79.log for details
822: You should also rm -Rf /tmp/rear.TXxhoWATfzryZVu
Terminated

It works with a device "usr/sbin/rear -s format /dev/sdb"
but in simulation mode it should work witout any further
command line parameters.

@jsmeix jsmeix reopened this Dec 23, 2016
@jsmeix jsmeix mentioned this issue Dec 23, 2016
Merged
jsmeix added a commit that referenced this issue Dec 23, 2016
@jsmeix
Merge pull request #1140 from jsmeix/implement_simulation_mode_for_fo…
6023381 
…rmat_workflow_issue1098

Implement simulation mode for format workflow.
Simulation mode for the format workflow should work
even without a device specified, see
#1098
@jsmeix
Copy link
Member Author

jsmeix commented Dec 23, 2016

With #1140 merged
simulation mode for the format workflow works now
even without a device specified.

@jsmeix jsmeix closed this as completed Dec 23, 2016
@jsmeix jsmeix mentioned this issue Oct 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsmeix jsmeix

Labels
fixed / solved / done minor bug An alternative or workaround exists
Projects
None yet
Milestone
Rear v2.00
Development

No branches or pull requests
1 participant
@jsmeix