Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXTERNAL_IGNORE_ERRORS not checked against RSYNC #2870

Closed
fadamo opened this issue Sep 28, 2022 · 6 comments
Closed

EXTERNAL_IGNORE_ERRORS not checked against RSYNC #2870

fadamo opened this issue Sep 28, 2022 · 6 comments
Labels
enhancement Adaptions and new features no-issue-activity

Comments

@fadamo
Copy link
Contributor

fadamo commented Sep 28, 2022

As per /usr/share/rear/backup/RSYNC/default/500_make_rsync_backup.sh, backup via rsyncd does not care about config:

```
# The following exit codes from EXTERNAL_* should not abort the backup or recovery
# This example is useful for rsync
EXTERNAL_IGNORE_ERRORS=( 23 24 )
```

as /usr/share/rear/backup/EXTERNAL/default/500_make_backup_with_external.sh instead does.
Using rsync vanished files are quite familiar.
Is it possible to include an exit code check in 500_make_rsync_backup.sh ?
@jsmeix jsmeix added the enhancement Adaptions and new features label Sep 28, 2022
@jsmeix
Copy link
Member

jsmeix commented Sep 28, 2022

Currently EXTERNAL_IGNORE_ERRORS is meant only for BACKUP=EXTERNAL
according to how it is described in default.conf
currently online starting at
https://github.com/rear/rear/blob/master/usr/share/rear/conf/default.conf#L2834

So what is needed is an enhancemnet for the BACKUP=RSYNC method
with a new separated config variable in default.conf
e.g. something similar as BORGBACKUP_IGNORE_WARNING
cf. #2846

@fadamo
Copy link
Contributor Author

fadamo commented Sep 28, 2022

OK, btw the comment "# This example is useful for rsync" is misleading imo.

jsmeix added a commit that referenced this issue Sep 29, 2022
@jsmeix
Improved comments in default.conf
40a9793 
In default.conf better description of the BACKUP=EXTERNAL config variables
see #2870 (comment)
and some general improvements of the comments in particular make blocks
of config variables that belong together more clear by using '####' as separators.
@jsmeix jsmeix mentioned this issue Sep 29, 2022
Merged
@jsmeix
Copy link
Member

jsmeix commented Sep 29, 2022

With #2872
there should be now a better (i.e. less misleading)
description of the BACKUP=EXTERNAL config variables
in default.conf.

@oldunclez
Copy link

@fadamo how do you deal with "rsync vanished files " right now ?

@fadamo
Copy link
Contributor Author

fadamo commented Sep 30, 2022

@fadamo how do you deal with "rsync vanished files " right now ?

I currently have an almost endless list of exclusions. I am studying how to "inject" an error check without modifying the original ReaR scripts, otherwise at the first "yum update" I lose the changes. However I think the correct solution is to do as in /usr/share/rear/backup/EXTERNAL/default/500_make_backup_with_external.sh.

jsmeix added a commit that referenced this issue Sep 30, 2022
@jsmeix
Merge pull request #2872 from rear/jsmeix-better-default-conf-comments
c32ff5e 
In default.conf more accurate description of BACKUP=EXTERNAL
and PING to better match what is actually implemented, see
#2870 (comment)
plus some general improvements of all the comments
e.g. removed the colloquial word 'stuff' where not useful and
made blocks of config variables that belong together more clear
by using '####' as indicators where a block begins and ends.
@github-actions
Copy link

Stale issue message

@github-actions github-actions bot closed this as completed Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Adaptions and new features no-issue-activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsmeix @oldunclez @fadamo