Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved comments in default.conf #2872

Merged
merged 3 commits into from Sep 30, 2022
Merged

Conversation

jsmeix
Copy link
Member

@jsmeix jsmeix commented Sep 29, 2022

In default.conf better description
of the BACKUP=EXTERNAL config variables, see
#2870 (comment)
and some general improvements of the comments
e.g. removed the colloquial word 'stuff' where not useful
and in particular make blocks of config variables
that belong together more clear by using

####
.
.
.
####

as indicators where a block begins and ends.

In default.conf better description of the BACKUP=EXTERNAL config variables
see #2870 (comment)
and some general improvements of the comments in particular make blocks
of config variables that belong together more clear by using '####' as separators.
@jsmeix jsmeix added the enhancement Adaptions and new features label Sep 29, 2022
@jsmeix jsmeix added this to the ReaR v2.8 milestone Sep 29, 2022
@jsmeix jsmeix requested a review from a team September 29, 2022 08:36
@jsmeix jsmeix self-assigned this Sep 29, 2022
More accurate description of BACKUP=EXTERNAL and PING
in default.conf to better match what is actually implemented.
@jsmeix
Copy link
Member Author

jsmeix commented Sep 29, 2022

I had a closer look what is actually implemented which results my latest
7714104

@jsmeix
Copy link
Member Author

jsmeix commented Sep 29, 2022

@rear/contributors
if there are no objections I would like to merge it
tomorrow afternoon.

Typo fix 'stetup' -> 'setup' and more explicit description
that the PING variable has ReaR's boolean semantics.
@jsmeix jsmeix merged commit c32ff5e into master Sep 30, 2022
@jsmeix jsmeix deleted the jsmeix-better-default-conf-comments branch September 30, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adaptions and new features fixed / solved / done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants