Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly support site.conf and don't hack local.conf #342

Closed
schlomo opened this issue Dec 5, 2013 · 3 comments
Closed

Properly support site.conf and don't hack local.conf #342

schlomo opened this issue Dec 5, 2013 · 3 comments
Assignees
Labels
bug The code does not do what it is meant to do fixed / solved / done
Milestone

Comments

@schlomo
Copy link
Member

schlomo commented Dec 5, 2013

While doing 08387b9 I realized (grep for local.conf) that there are places where we check local.conf for a configuration setting and there are other places where we write to local.conf.

Example: If users use site.conf to configure the use of DHCP in the rescue system then it won't work.

I think that this is very dangerous. Why not use the rescue.conf which is read after the local.conf for that purpose? Also, instead of greping local.conf for configuration items we should be sourcing in the ReaR configuration and use the value if set.

@ghost ghost assigned gdha Dec 9, 2013
@gdha
Copy link
Member

gdha commented Dec 9, 2013

I'll improve the ./prep/GNU/Linux/21_include_dhclient.sh script some time later

gdha added a commit that referenced this issue Jan 8, 2014
…defined variables instead (issue #342);

added short license text (issue #116); replaced tabs by 4-spaces (issue #6)
@gdha gdha modified the milestones: Rear v1.17, Rear v1.16 Apr 14, 2014
@gdha
Copy link
Member

gdha commented Dec 5, 2014

@Reiner030 when you enhanced the rules of Debian packaging did you notice if the local.conf file got overwriiten?

@gdha
Copy link
Member

gdha commented Feb 16, 2015

added to the release notes so we can close this issue

@gdha gdha closed this as completed Feb 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The code does not do what it is meant to do fixed / solved / done
Projects
None yet
Development

No branches or pull requests

2 participants