Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nano, dhcp client, sshd start to bash history #1306

Merged
merged 3 commits into from
Apr 19, 2017

Conversation

ProBackup-nl
Copy link
Contributor

Some handy command the help me getting (debug) things done, in the Rear recovery environment.

ProBackup-nl added 2 commits April 16, 2017 12:13
Some handy command the help me getting (debug) things done, in the Rear recovery environment.
@gdha gdha self-assigned this Apr 18, 2017
@gdha gdha added the enhancement Adaptions and new features label Apr 18, 2017
@gdha gdha added this to the ReaR v2.1 milestone Apr 18, 2017
@gdha
Copy link
Member

gdha commented Apr 18, 2017

@ProBackup-nl No objections against it - so I approve/accept it

@gdha gdha requested review from gdha and jsmeix April 18, 2017 13:01
Alignded the trailing comments to same column
to keep the look as it was before.
Copy link
Member

@jsmeix jsmeix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I found out how to do
simple changes directly in the
pull request so that I aligned the
comments to the same column
to keep the look.

@jsmeix jsmeix merged commit 157c8dc into rear:master Apr 19, 2017
@ProBackup-nl
Copy link
Contributor Author

@jsmeix
Due to comment:

-----------------------------------------------------80-|

I though the convention here, is to make comments that fit within 80 characters. That is why I didn't left align them. Should the 80 character rule(r) comment be kept or removed?

@jsmeix
Copy link
Member

jsmeix commented Apr 21, 2017

I think that comment is more a hint that a strict rule
because ist string length is 60 characters.
Some characters are needed for the bash prompt
in the recovery system but I think the current is still o.k.
And even if it exceeds what fits on a line on a small terminal
it is only a cosmetic issue.

@jsmeix
Copy link
Member

jsmeix commented Apr 21, 2017

This pull request is somehow related to
#1298

@ProBackup-nl ProBackup-nl deleted the patch-16 branch May 10, 2017 20:38
jsmeix added a commit that referenced this pull request Feb 19, 2024
…3154)

Create an empty
usr/share/rear/skel/default/root/.vimrc
to fix #3151
Furthermore in build/GNU/Linux/130_create_dotfiles.sh
dynamically generate .bash_history entries depending on
whether or not 'nano' and 'vi' are available, see
#3151 (comment)
and see #1306 regarding nano
and #1298 when vi is not available.
lzaoral pushed a commit to lzaoral/rear that referenced this pull request Feb 27, 2024
…ear#3154)

Create an empty
usr/share/rear/skel/default/root/.vimrc
to fix rear#3151
Furthermore in build/GNU/Linux/130_create_dotfiles.sh
dynamically generate .bash_history entries depending on
whether or not 'nano' and 'vi' are available, see
rear#3151 (comment)
and see rear#1306 regarding nano
and rear#1298 when vi is not available.
lzaoral pushed a commit to lzaoral/rear that referenced this pull request Mar 5, 2024
…ear#3154)

Create an empty
usr/share/rear/skel/default/root/.vimrc
to fix rear#3151
Furthermore in build/GNU/Linux/130_create_dotfiles.sh
dynamically generate .bash_history entries depending on
whether or not 'nano' and 'vi' are available, see
rear#3151 (comment)
and see rear#1306 regarding nano
and rear#1298 when vi is not available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adaptions and new features fixed / solved / done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants