Fix issue 3151: missing .vimrc and overhauled 130_create_dotfiles.sh #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In build/GNU/Linux/130_create_dotfiles.sh dynamically generate .bash_history entries depending on whether or not 'nano' and 'vi' are available, see #3151 (comment)
|
@rear/contributors |
In comment use simpler estimate numbers 20 and 60 instead of 21 and 59
lzaoral
pushed a commit
to lzaoral/rear
that referenced
this pull request
Feb 27, 2024
…ear#3154) Create an empty usr/share/rear/skel/default/root/.vimrc to fix rear#3151 Furthermore in build/GNU/Linux/130_create_dotfiles.sh dynamically generate .bash_history entries depending on whether or not 'nano' and 'vi' are available, see rear#3151 (comment) and see rear#1306 regarding nano and rear#1298 when vi is not available.
lzaoral
pushed a commit
to lzaoral/rear
that referenced
this pull request
Mar 5, 2024
…ear#3154) Create an empty usr/share/rear/skel/default/root/.vimrc to fix rear#3151 Furthermore in build/GNU/Linux/130_create_dotfiles.sh dynamically generate .bash_history entries depending on whether or not 'nano' and 'vi' are available, see rear#3151 (comment) and see rear#1306 regarding nano and rear#1298 when vi is not available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Minor Bug Fix
Impact: Low
Reference to related issue (URL):
SLES15 SP5: vi: E1187: Failed to source defaults.vim #3151
How was this pull request tested?
Tested with SLES15-SP5.
It works well for me.
Description of the changes in this pull request:
Create an empty
usr/share/rear/skel/default/root/.vimrc
and delete the now false (directory no longer empty)
usr/share/rear/skel/default/root/.gitignore
because (as far as I vaguely remember)
we have such .gitignore files so that we can
have empty directories in git as described e.g. in
https://stackoverflow.com/questions/115983/how-do-i-add-an-empty-directory-to-a-git-repository
In build/GNU/Linux/130_create_dotfiles.sh
dynamically generate .bash_history entries
depending on whether or not 'nano' and 'vi' are available,
see #3151 (comment)