Fix for 'error:unrecognized number' when booting ISO on PPC #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue is caused by incorrect, according to PAPR specification, bootinfo entity parsing code in grub2. In PAPR spec "B.4.1.6.1 Bootinfo Entities" partition and path separator (,) is optional and if not present bootinfo may be treated as directory and filename components unless it begins with number: &device;:[&partition;][,]&directory;&filename; If (,) is missing and directory begins with a hexadecimal number GRUB2 treats this as partition number immediately followed by a directory/filename. Note that with (,) present in bootpath issue isn't in the case as GRUB2 returns empty string for GRUB_PARSE_PARTITIONS. This effectively meaning that GRUB2 code requires (,) as mandatory. This is a GRUB2 bug, but until it is fixed, we can make the message disappear by specifying a comma in bootinfo.txt. Signed-off-by: Renaud Métrich <rmetrich@redhat.com>
|
@schabrolles |
gdha
approved these changes
Dec 5, 2018
|
@schabrolles |
|
@schabrolles It's as simple as making an ISO and booting it :-) |
|
Hi team, I'm currently testing it ... Sorry for the delay, as you say I'm a bit overloaded and I've completely forgotten to test it. |
jsmeix
added
fixed / solved / done
bug
|
@rmetrich @schabrolles |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax-and-Recover (ReaR) Pull Request Template
Please fill in the following items before submitting a new pull request:
Pull Request Details:
Type: Bug Fix
Impact: Low
Reference to related issue (URL): No issue created
How was this pull request tested? Not tested, I don't have the hardware for now, please may someone with hardware test.
Brief description of the changes in this pull request: