Simplify awk constructs in 320_include_uefi_env.sh (issue #2095) #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gozora
approved these changes
Apr 11, 2019
| # First try /boot/efi: | ||
| esp_proc_mounts_line=( $( grep ' /boot/efi ' /proc/mounts || echo false ) ) | ||
| if is_false $esp_proc_mounts_line ; then | ||
| # If nothing is mounted on on /boot/efi try /boot: |
jsmeix
deleted the
simplify_awk_constructs_in_320_include_uefi_env_sh_issue2095
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Bug Fix
Impact: Normal
Reference to related issue (URL):
Creating UEFI Bootable USB stick hangs while reading /proc/mounts #2095
How was this pull request tested?
Seems to work well for me on openSUSE Leap 15.0
The - from my point of view - needlessly overcomplicated
local variables (sometimes uppercased) and their
awkconstructsare simplified into using plain
grepand a bash arrayto avoid inexplicable wrong behaviour in some cases
that is somehow related to the
nullglobbash option, cf.#2095 (comment)
together with different kind of
awk, cf.#2095 (comment)
Additionally there is better user info in debug mode via
DebugPrint(in particular when things do not work as usually expected).