New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
500_make_backup.sh: fix exit code logic #2470
Conversation
Commit 2674807 removed the BACKUP_PROG_CRYPT_OPTIONS="cat" which breaks the exit code logic because pipes_rc and backup_prog_shortnames does no longer match. Ensure that the number of elements in both variables are alwas the same. Signed-off-by: Carlos Santos <casantos@redhat.com>
What I like more with your implementation here Now I am wondering if we could also get rid of the useless use of On the other hand I wonder if that overall cleanup should be done now or if it is better for now |
I'm not against a deep overhauling but I'd prefer to do it in baby steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@rear/contributors |
Fixed comment about the return code of the backup subshell and improved some other comments a bit.
@casantos |
Type: Bug Fix
Impact: Normal
Reference to related issue (URL): 500_make_backup.sh: filter informational tar messages from output #2466 (comment)
How was this pull request tested?
Ran a backup ensuring that there is not enough space in the destination to write backup.tar.gz.
Commit 2674807 removed the BACKUP_PROG_CRYPT_OPTIONS="cat" which breaks
the exit code logic because pipes_rc and backup_prog_shortnames does no
longer match.
Ensure that the number of elements in both variables are alwas the same.
Signed-off-by: Carlos Santos casantos@redhat.com