Fixed exit logic in 500_make_backup.sh plus issue 2465 #2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 500_make_backup.sh fixed what I did wrong in 2674807 where I had removed the BACKUP_PROG_CRYPT_OPTIONS="cat" which breaks the exit code logic around pipes_rc=( ${PIPESTATUS[@]} ) because backup_prog_shortnames does no longer match. Additionally filter informational tar messages from output cf. #2465
jsmeix
added
enhancement
This was referenced Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Bug Fix and Enhancement
Impact: Normal
Reference to related issue (URL):
500_make_backup.sh: filter informational tar messages from output #2466 (comment)
and
rear shows misleading "socket ignored" information when tar end with exit code 1 #2465
How was this pull request tested?
Not yet tested at all.
Brief description of the changes in this pull request:
In 500_make_backup.sh fixed the exit code logic that I had messed up via
2674807
where I had removed the BACKUP_PROG_CRYPT_OPTIONS="cat"
which breaks the exit code logic around pipes_rc=( ${PIPESTATUS[@]} )
because backup_prog_shortnames does no longer match.
Additionally filter informational tar messages from output
cf. #2465