New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set 'dmesg -n [4-7]' in sbin/rear #3112
Conversation
Wouldn't it be better (more modular) to put the code into a script under |
@pcahyna |
is it necessary to introduce a difference between
so there should be no difference between |
me too. I already saw |
Argh!
I.e. I confused /etc/rear/rescue.conf with /etc/rear-release |
I think I will move the "set 'dmesg -n [4-7]' code" from sbin/rear |
init is sourced always though: |
Consider the above only a minor remark. I don't like putting more code into |
In sbin/rear we have already
which was introduced by I will use RECOVERY_MODE for the "set 'dmesg -n [4-7]' code" |
According to init/default/050_check_rear_recover_mode.sh the workflows So the question is whether or not Of course it does not matter whether or not But should |
@pcahyna
Interestingly Fortunately I am not too greedy so I won't dig deeper here
;-) |
This one is obsoleted by |
@pcahyna |
Type: Enhancement
Impact: Normal
Reference to related issues:
Debug intermittent backup/recovery CI errors #3107
Set 'dmesg -n 5' in etc/scripts/boot #3108
How was this pull request tested?
Not yet tested
Description of the changes in this pull request:
In sbin/rear
find out if we're running inside the recovery system
and if yes call 'dmesg -n [4-7]' depending on
verbose and debug modes for ReaR.
In contrast to what I wrote in
#3107 (comment)
I set here
dmesg -n 4
as minimum i.e. in non verbose modedmesg -n 5
in verbose and debug modedmesg -n 6
in debugscript mode (with '-D' option)dmesg -n 7
onyl with the long '--debugscripts' optionbecause dmesg log level 7 shows lots of (mostly useless)
informational messages that are normally not helpful
for debugging issues during 'rear recover'
but those many informational kernel messages
disturb the intended ReaR recovery messages and
in particular those needless kernel messages make
the intended ReaR recovery messages scroll away
out of sight too soon on console, cf.
#3107 (comment)
because I think the usual default is dmesg log level 7
In general:
If 'dmesg -n 8' (or something else) is needed
it can be called via PRE_RECOVERY_COMMANDS
so what we set here is only the default behaviour.