New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set 'dmesg -n [4-6]' in new 'setup' script 007_set_dmesg_level.sh #3113
Conversation
The new 'setup' stage script setup/default/007_set_dmesg_level.sh sets 'dmesg -n [4-6]' for the worksflows recover layoutonly restoreonly finalizeonly mountonly depending on verbose and debug modes for ReaR. This is related to #3108
Use 'dmesg level' instead of 'dmesg log level' because "man dmesg" talks about just 'level' in contrast to 'dmesg -h' but simpler is better
local dmesg_level
DebugPrint "Setting dmesg level $dmesg_level" so the user could see in debug mode why kernel messages appear intermixed with ReaR messages on console
@rear/contributors |
Only a nit, but is it intended to leave the first and last line of the file empty? |
In contrast to what I wrote in
I tested this pull request on another VM
Therefore I added
so the user could see in debug mode why kernel messages |
@pcahyna |
@jsmeix I would now to recommend to squash the first three commits together and force push. Then, when merging, use the usual procedure (create a merge commit). |
@pcahyna |
Normally I use only the GitHub web frontend to implement changes Normally I do not implement things on a local git checkout I test pull requests via git clone and git checkout My personal reasons are: Since more and more "doing work" changes from
My personal reason behind those reasons is |
Type: Enhancement
Impact: Normal
Reference to related issue (URL):
Set 'dmesg -n 5' in etc/scripts/boot #3108
How was this pull request tested?
I tested it and it works well for me.
Description of the changes in this pull request:
The new 'setup' stage script setup/default/007_set_dmesg_level.sh
sets 'dmesg -n [4-6]' for the worksflows
recover layoutonly restoreonly finalizeonly mountonly
depending on verbose and debug modes for ReaR.
This pull request obsoletes
#3112