Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate MAC addresses and interface names in NetworkManager keyfiles during network configuration migration #3179

Merged
merged 4 commits into from
Jul 12, 2024

Commits on Mar 14, 2024

  1. Migrate NM keyfiles during network conf migration

    See
    https://fedoramagazine.org/converting-networkmanager-from-ifcfg-to-keyfiles/
    for more details on NetworkManager keyfiles.
    
    Only MAC addresses and interface names are migrated for now.
    
    TODO: migrate also IP addresses and routes.
    pcahyna committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    01d5fb5 View commit details
    Browse the repository at this point in the history
  2. Quote name when assembling network files to patch

    Otherwise patching fails on files with spaces in them, often used by
    NetworkManager:
    
    Failed to rewrite MAC addresses and network interfaces in /mnt/local/etc/NetworkManager/system-connections/ZSSK
    Failed to rewrite MAC addresses and network interfaces in WIFI.nmconnection
    
    (the original file is named 'ZSSK WIFI.nmconnection').
    pcahyna committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    fe60e55 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Quote network config filenames in log messages

    It is our common practice to log and show messages with single-quoted
    file names like "Processed the file 'file name'" and it is
    especially useful with file names containing spaces.
    pcahyna committed Mar 15, 2024
    1 Configuration menu
    Copy the full SHA
    5ea58a7 View commit details
    Browse the repository at this point in the history
  2. Properly test for empty array

    Instead of chjecking whether the first member of the array is empty,
    check whether the array is actually empty.
    pcahyna committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    fd4c064 View commit details
    Browse the repository at this point in the history