Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Type correction for URLSearchParams #123

Merged
merged 3 commits into from
Feb 9, 2019

Conversation

SamWyld
Copy link
Contributor

@SamWyld SamWyld commented Feb 5, 2019

Fixes #122

Copy link
Member

@glennsl glennsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It should be enough to add bs.return to it though, which preserves the better option type and has the additional benefit of not being a breaking change:

[@bs.return nullable][@bs.send.pipe : t] external get: string => option(string) = "";

Could you try that instead?

Make get return an option
@SamWyld
Copy link
Contributor Author

SamWyld commented Feb 7, 2019

Yeah I agree. I have made the change 😄

@glennsl
Copy link
Member

glennsl commented Feb 9, 2019

Thanks!

@glennsl glennsl merged commit d04fff8 into reasonml-community:master Feb 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants