Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

URLSearchParams.get returns incorrect type #122

Closed
SamWyld opened this issue Feb 4, 2019 · 1 comment
Closed

URLSearchParams.get returns incorrect type #122

SamWyld opened this issue Feb 4, 2019 · 1 comment

Comments

@SamWyld
Copy link
Contributor

SamWyld commented Feb 4, 2019

Currently the type of get in URLSearchParamsRe.re is:
[@bs.send.pipe : t] external get: string => option(string) = "";

As you can see in the documentation here

The type I think should be:
[@bs.send.pipe : t] external get: string => Js.Nullable.t(string) = "";

Quite happy to make a PR if I am correct about this :)

@glennsl
Copy link
Member

glennsl commented Feb 6, 2019

Indeed it should, thanks! Closing in favor of #123.

@glennsl glennsl closed this as completed Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants