New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make optional props optional properly #776

Merged

davesnx merged 10 commits into main from Fix-optional-props-in-props

Sep 13, 2023

Member

davesnx commented Sep 7, 2023 •

edited

Loading

Fixes #618

davesnx added 2 commits

September 7, 2023 13:08


          Make optional props optional and key no

f03371a


          Add case for more props

e9d8859

davesnx mentioned this pull request

[ppx] Make optional props behave properly #775

Closed

anmonteiro reviewed

View reviewed changes

ppx/reason_react_ppx.ml Outdated Show resolved Hide resolved

davesnx added 8 commits

September 11, 2023 15:30


          Embarrasing print

ed9c728


          Merge branch 'main' of github.com:/reasonml/reason-react into Fix-opt…

3ce1e5e

…ional-props-in-props

* 'main' of github.com:/reasonml/reason-react:
  Bump React depext to v17-18 (#777)


          Use ppx.sh

7d128ed


          Add usage on ppxsh

0dd6be2


          Remove unused sh script

0eebb92


          Merge branch 'main' into Fix-optional-props-in-props

479e821


          Good doc chaanges

f6d96bd


          Add reason upper bound to 3.10.0

d0802a5

davesnx merged commit 0a98c07 into main

2 of 4 checks passed

davesnx deleted the Fix-optional-props-in-props branch

September 13, 2023 07:00

davesnx added a commit to davesnx/opam-repository that referenced this pull request


          [new release] reason-react and reason-react-ppx (0.12.0)

d7c1691

CHANGES:

* Migrate the reason-react PPX and library to the [new React JSX
transform](https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html)
  (@anmonteiro in [reasonml/reason-react#714](reasonml/reason-react#714))
* Add `suppressHydrationWarning` to supported props (@davesnx in
[reasonml/reason-react#721](reasonml/reason-react#721))
* Rename `reactjs-jsx-ppx` to `reason-react-ppx` ([@davesnx in reasonml/reason-react#732](reasonml/reason-react#732))
* Fix locations for lower and uppercase components so that merlin / editor
  integration can get type defs on hover ([@jchavarri in reasonml/reason-react#748](reasonml/reason-react#748))
* Refine types for `key` attributes ([@anmonteiro in reasonml/reason-react#750](reasonml/reason-react#750))
* Bump React depext to v17-18 reasonml/reason-react#777 ([@jchavarri in reasonml/reason-react#777](https://github.com/reasonml/reason-react/pull/777/files))
* Make optional props optional properly
 ([@davesnx in reasonml/reason-react#776](reasonml/reason-react@0a98c07))

davesnx added a commit to davesnx/opam-repository that referenced this pull request


          [new release] reason-react and reason-react-ppx (0.12.0)

e397e69

CHANGES:

* Migrate the reason-react PPX and library to the [new React JSX
transform](https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html)
  (@anmonteiro in [reasonml/reason-react#714](reasonml/reason-react#714))
* Add `suppressHydrationWarning` to supported props (@davesnx in
[reasonml/reason-react#721](reasonml/reason-react#721))
* Rename `reactjs-jsx-ppx` to `reason-react-ppx` ([@davesnx in reasonml/reason-react#732](reasonml/reason-react#732))
* Fix locations for lower and uppercase components so that merlin / editor
  integration can get type defs on hover ([@jchavarri in reasonml/reason-react#748](reasonml/reason-react#748))
* Refine types for `key` attributes ([@anmonteiro in reasonml/reason-react#750](reasonml/reason-react#750))
* Bump React depext to v17-18 reasonml/reason-react#777 ([@jchavarri in reasonml/reason-react#777](https://github.com/reasonml/reason-react/pull/777/files))
* Make optional props optional properly
 ([@davesnx in reasonml/reason-react#776](reasonml/reason-react@0a98c07))

davesnx added a commit to davesnx/opam-repository that referenced this pull request


          [new release] reason-react and reason-react-ppx (0.12.0)

bdcf1ce

CHANGES:

* Migrate the reason-react PPX and library to the [new React JSX
transform](https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html)
  (@anmonteiro in [reasonml/reason-react#714](reasonml/reason-react#714))
* Add `suppressHydrationWarning` to supported props (@davesnx in
[reasonml/reason-react#721](reasonml/reason-react#721))
* Rename `reactjs-jsx-ppx` to `reason-react-ppx` ([@davesnx in reasonml/reason-react#732](reasonml/reason-react#732))
* Fix locations for lower and uppercase components so that merlin / editor
  integration can get type defs on hover ([@jchavarri in reasonml/reason-react#748](reasonml/reason-react#748))
* Refine types for `key` attributes ([@anmonteiro in reasonml/reason-react#750](reasonml/reason-react#750))
* Bump React depext to v17-18 reasonml/reason-react#777 ([@jchavarri in reasonml/reason-react#777](https://github.com/reasonml/reason-react/pull/777/files))
* Make optional props optional properly
 ([@davesnx in reasonml/reason-react#776](reasonml/reason-react@0a98c07))

anmonteiro mentioned this pull request

fix: remove redundant check related to option(_) labelled props #799

Merged

nberth pushed a commit to nberth/opam-repository that referenced this pull request


          [new release] reason-react and reason-react-ppx (0.12.0)

6380a93

CHANGES:

* Migrate the reason-react PPX and library to the [new React JSX
transform](https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html)
  (@anmonteiro in [reasonml/reason-react#714](reasonml/reason-react#714))
* Add `suppressHydrationWarning` to supported props (@davesnx in
[reasonml/reason-react#721](reasonml/reason-react#721))
* Rename `reactjs-jsx-ppx` to `reason-react-ppx` ([@davesnx in reasonml/reason-react#732](reasonml/reason-react#732))
* Fix locations for lower and uppercase components so that merlin / editor
  integration can get type defs on hover ([@jchavarri in reasonml/reason-react#748](reasonml/reason-react#748))
* Refine types for `key` attributes ([@anmonteiro in reasonml/reason-react#750](reasonml/reason-react#750))
* Bump React depext to v17-18 reasonml/reason-react#777 ([@jchavarri in reasonml/reason-react#777](https://github.com/reasonml/reason-react/pull/777/files))
* Make optional props optional properly
 ([@davesnx in reasonml/reason-react#776](reasonml/reason-react@0a98c07))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment