feat: wrap the React library #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchavarri
approved these changes
Sep 15, 2023
davesnx
reviewed
Sep 15, 2023
| @@ -0,0 +1,1117 @@ | |||
| /* First time reading an OCaml/Reason/BuckleScript file? */ | |||
There was a problem hiding this comment.
I would keep ReactDOM as a toplevel, since it matches what react exposes and keep it as a good default, where 1 module from reason-react binds to one exportable from react.js
There was a problem hiding this comment.
this would need a new library, e.g. react.dom, which I don't think is a good tradeoff.
There was a problem hiding this comment.
I kind of like the new library actually (since react.native) can be their own thing also...
anmonteiro
force-pushed
the
anmonteiro/wrap
branch
from
84a4d83
to
4d81337
Compare
davesnx
pushed a commit
that referenced
this pull request
Sep 19, 2023
anmonteiro
added a commit
that referenced
this pull request
Sep 20, 2023
anmonteiro
added a commit
that referenced
this pull request
Sep 20, 2023
davesnx
added a commit
to davesnx/opam-repository
that referenced
this pull request
Feb 10, 2024
CHANGES: * Wrap the `React` library, exposing just a single top-level module (@anmonteiro in [reasonml/reason-react#783](reasonml/reason-react#783)) * Re-organise toplevel modules (@davesnx in [reasonml/reason-react#794](reasonml/reason-react#794)) * Require and adapt to Melange v3 (@anmonteiro in [reasonml/reason-react#821](reasonml/reason-react#821))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #770
supersedes #773