Melange v3 long-lived branch #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2023
anmonteiro
force-pushed
the
anmonteiro/melange-v3
branch
from
41e3ba2
to
b0b8d07
Compare
anmonteiro
force-pushed
the
anmonteiro/melange-v3
branch
from
1f084f4
to
4a950d4
Compare
jchavarri
approved these changes
Feb 2, 2024
| "type": "(~greeting: string) => React.element", | ||
| "type": "(~greeting: string) => element", |
There was a problem hiding this comment.
These changes are strange, I assume is the new merlin version used? I can't see anything in reason-react itself that changed, or in melange.
There was a problem hiding this comment.
I don't understand why these changed, but they're both correct and consistent across opam / nix calls, so I didn't worry too much.
| }, | ||
| "end": { | ||
| "line": 10, | ||
| "col": 85 | ||
| }, | ||
| "type": "{.. \"author\": Author.t} => React.element", | ||
| "type": "string", |
There was a problem hiding this comment.
This is also strange, but I guess now it's more accurate (I think this test is hovering over key prop, from what I see in line 21).
|
I went ahead and restored the branch here. If your builds somehow failed because this melange-v3 branch was missing, please retry the build! |
davesnx
added a commit
to davesnx/opam-repository
that referenced
this pull request
Feb 10, 2024
CHANGES: * Wrap the `React` library, exposing just a single top-level module (@anmonteiro in [reasonml/reason-react#783](reasonml/reason-react#783)) * Re-organise toplevel modules (@davesnx in [reasonml/reason-react#794](reasonml/reason-react#794)) * Require and adapt to Melange v3 (@anmonteiro in [reasonml/reason-react#821](reasonml/reason-react#821))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.