<JSX> ☲ "Simplified" version of Sander's diff. #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is a version of Sander's JSX implementation which treats
JSX as "simple" constructs, meaning they are "clearly one unit", and do
not require parenthesis to be wrapped around them in order to be passed
as function arguments. That means you can treat <tag ...> as the
"opening paren" and "</tag>" as the closing paren.
This diff also supports:
- Frags (which are simply lists that don't require commas separating
contents).
- Lists of JSX items
```
let myFunction =
callSomeFunction
<FirstItem>foo</FirstItem>
<SecondItem>foo</SecondItem>;
let lst = [<Tag />, <AnotherTag />];
let lst =
<>
<Tag />
<AnotherTag />
</>;
```
Whats Not Implemented: Currently, the limitation of this approach is
that subsequent JSX elements must always have spaces separating them.
I have a good idea about how to solve that limitation, but we can start
using this right now, in an experimental mode.
```
let items = <Wrapper> <This /> <Must /> <Have /> <Spaces /> </Wrapper>
```
Test Plan:Test cases.
Reviewers:
CC: @vjeux
ghost
added
bsansouci
reviewed
Sep 20, 2016
|
|
||
| let lowerCase = <div argument1=1 />; | ||
|
|
||
| let a = <Foo a>5 </Foo>; |
There was a problem hiding this comment.
Is this the string 5, or seen as {5}? (maybe this doesn't matter here actually...)
There was a problem hiding this comment.
It's the number 5. We may want to change how children are represented, or at least printed. Right now, the current JavaScript JSX conventions are a special case of what's supported. In Reason, the expression {5} is the same as 5 (verify for yourself - it's just a sequence expression with one item returned). So we could print it as <Foo>{5}</Foo>
|
|
||
| let a = <Foo a>5 </Foo>; | ||
|
|
||
| let a = <Foo a>0.55 </Foo>; |
There was a problem hiding this comment.
Oh, that seems to be a mistake. Will fix.
| the issue alltogether. | ||
|
|
||
| first token | ||
| / \ |
There was a problem hiding this comment.
Should these be aligned with <ident and args />?
|
@bsansouci Want to start adapting this to Cheng Lou's needs? |
jordwalke
changed the title
|
I'll commit this, and then if anyone has issues with it, I'll gladly fix them or revert it. Ben needs this in to rebase his changes off of. |
Closed
bsansouci
pushed a commit
to bsansouci/reason
that referenced
this pull request
Sep 29, 2016
* [JSX] JSX: "Simplified" version of Sander's diff.
Summary: This is a version of Sander's JSX implementation which treats
JSX as "simple" constructs, meaning they are "clearly one unit", and do
not require parenthesis to be wrapped around them in order to be passed
as function arguments. That means you can treat <tag ...> as the
"opening paren" and "</tag>" as the closing paren.
This diff also supports:
- Frags (which are simply lists that don't require commas separating
contents).
- Lists of JSX items
```
let myFunction =
callSomeFunction
<FirstItem>foo</FirstItem>
<SecondItem>foo</SecondItem>;
let lst = [<Tag />, <AnotherTag />];
let lst =
<>
<Tag />
<AnotherTag />
</>;
```
Whats Not Implemented: Currently, the limitation of this approach is
that subsequent JSX elements must always have spaces separating them.
I have a good idea about how to solve that limitation, but we can start
using this right now, in an experimental mode.
```
let items = <Wrapper> <This /> <Must /> <Have /> <Spaces /> </Wrapper>
```
Test Plan:Test cases.
Reviewers:
CC: @vjeux
* More fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is a version of Sander's JSX Pull Request, but rebased on top of our recent large refactors, and modified to treat
JSX as "simple" constructs, meaning they are "clearly one unit", and do
not require parenthesis to be wrapped around them in order to be passed
as function arguments. That means you can treat <tag ...> as the
"opening paren" and "" as the closing paren.
This diff also supports:
contents).
Whats Not Implemented: Currently, the limitation of this approach is
that subsequent JSX elements must always have spaces separating them.
I have a good idea about how to solve that limitation, but we can start
using this right now, in an experimental mode.
Test Plan:Test cases.
Reviewers: