Update mustache #146

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@evax
Contributor

evax commented Sep 21, 2013

This adds support for inverted {{^name}}{{/name}} sections.

@tuncer

This comment has been minimized.

Show comment Hide comment
@tuncer

tuncer Sep 21, 2013

Contributor

Thanks @evax, +1.

Contributor

tuncer commented Sep 21, 2013

Thanks @evax, +1.

@Vagabond

This comment has been minimized.

Show comment Hide comment
@Vagabond

Vagabond Feb 6, 2014

Contributor

This PR is a little stale, someone renamed mustache to rebar_mustache. Can we get an update?

Contributor

Vagabond commented Feb 6, 2014

This PR is a little stale, someone renamed mustache to rebar_mustache. Can we get an update?

@evax

This comment has been minimized.

Show comment Hide comment
@evax

evax Feb 6, 2014

Contributor

Will do (@tuncer paved the way it seems, thanks!)

Contributor

evax commented Feb 6, 2014

Will do (@tuncer paved the way it seems, thanks!)

@evax

This comment has been minimized.

Show comment Hide comment
@evax

evax Feb 6, 2014

Contributor

@tuncer: interesting, I can't get upstream mustache tests to pass, apparently due to a rebar issue :)
It looks like although skip-deps is set to true rebar is trying to compile modules in deps/meck/test/ and fails to do so because of a test-only dependency on hamcrest-erlang.

Contributor

evax commented Feb 6, 2014

@tuncer: interesting, I can't get upstream mustache tests to pass, apparently due to a rebar issue :)
It looks like although skip-deps is set to true rebar is trying to compile modules in deps/meck/test/ and fails to do so because of a test-only dependency on hamcrest-erlang.

@Vagabond

This comment has been minimized.

Show comment Hide comment
@Vagabond

Vagabond Mar 5, 2014

Contributor

Still waiting for motion on this.

Contributor

Vagabond commented Mar 5, 2014

Still waiting for motion on this.

@tuncer

This comment has been minimized.

Show comment Hide comment
@tuncer

tuncer May 29, 2014

Contributor

ping

Contributor

tuncer commented May 29, 2014

ping

@evax

This comment has been minimized.

Show comment Hide comment
@evax

evax May 29, 2014

Contributor

hi @tuncer, I was blocked by the testing issue above, I should give it another shot

Contributor

evax commented May 29, 2014

hi @tuncer, I was blocked by the testing issue above, I should give it another shot

@tuncer

This comment has been minimized.

Show comment Hide comment
@tuncer

tuncer May 29, 2014

Contributor

Thanks.

Contributor

tuncer commented May 29, 2014

Thanks.

@tsloughter tsloughter closed this Jun 15, 2014

@tuncer

This comment has been minimized.

Show comment Hide comment
@tuncer

tuncer Jun 15, 2014

Contributor

@tsloughter why did you close this?

Contributor

tuncer commented Jun 15, 2014

@tsloughter why did you close this?

@ferd

This comment has been minimized.

Show comment Hide comment
@ferd

ferd Jun 15, 2014

Contributor

Hi, this issue was closed in an attempt to do quick basic filtering, with the benediction of rebar project owners. These issues and pull requests are not issues or code we're spitting on, but given the burden of the task and how much code rot may have happened since these were open is unknown from maintainers at this time. All tickets prior to March 2014 were closed and will be reopened on a per-request basis if we see interest from the reporter or contributor, or if some of the issues reported are still valid after the various patches that have made it since they were opened.

This is a fairly brutal first step to help us get a proper understanding of what is still valid or not, but that has been proven efficient in the past. Sorry for the inconvenience, things should go smoother from there on.

Contributor

ferd commented Jun 15, 2014

Hi, this issue was closed in an attempt to do quick basic filtering, with the benediction of rebar project owners. These issues and pull requests are not issues or code we're spitting on, but given the burden of the task and how much code rot may have happened since these were open is unknown from maintainers at this time. All tickets prior to March 2014 were closed and will be reopened on a per-request basis if we see interest from the reporter or contributor, or if some of the issues reported are still valid after the various patches that have made it since they were opened.

This is a fairly brutal first step to help us get a proper understanding of what is still valid or not, but that has been proven efficient in the past. Sorry for the inconvenience, things should go smoother from there on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment