This repository has been archived by the owner on May 12, 2018. It is now read-only.
Add REBAR to environment before executing hooks #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Path = escript:script_name(), | ||
| [{"REBAR", Path} | Env0] | ||
| catch | ||
| _:_ -> % rebar was involed programmatically |
|
Note, it really needs to be BTW, this is already stored in xconf here: |
|
@uwiger good catch, that can and should be reused. |
| []; | ||
| patch_env([{env, Env0} | Rest]) -> | ||
| Env = try | ||
| Path = escript:script_name(), |
There was a problem hiding this comment.
As @uwiger suggested, we should reuse the existing xconf variable here:
Path = rebar_config:get_xconf(Config, escript, ""),
|
Thanks guys, I've updated the PR. |
| @@ -314,6 +315,21 @@ processing_base_dir(Config) -> | |||
| processing_base_dir(Config, Dir) -> | |||
| Dir =:= rebar_config:get_xconf(Config, base_dir). | |||
|
|
|||
| %% @doc Returns list of environment variables including 'REBAR' which points to the rebar executable used to execute the currently running command. The environment is not modified if rebar was invoked programmatically. | |||
|
This looks fine, just needs a rebase. |
|
What's the status? |
REBAR will be set to the rebar binary which was executed and runs the
builds. Enables the use of the same binary for rebar invocations as
part of a pre or post hook like so:
${REBAR} escriptize
|
I've rebased the patch. It's been in use without issues. |
tsloughter
added a commit
that referenced
this pull request
Jun 14, 2014
Add REBAR to environment before executing hooks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REBAR will be set to the rebar binary which was executed and runs the
builds. Enables the use of the same binary for rebar invocations as
part of a pre or post hook like so: