-
Notifications
You must be signed in to change notification settings - Fork 296
Conversation
Thanks @nevar.
|
|
Right, that leaves just |
|
Add editor mode line header |
Thanks, while at it, feel free to add it where missing to all files in |
After a debug session with @nevar, I think the root cause is that we don't have separate |
A more descriptive commit message would be:
|
@@ -1,6 +1,8 @@ | |||
%% -*- mode: erlang;erlang-indent-level: 4;indent-tabs-mode: nil -*- | |||
%% ex: ts=4 sw=4 ft=erlang et | |||
{erl_first_files, ["first_xrl.erl", "first_yrl.erl"]}. | |||
{erl_first_files, ["first_xrl.erl", "first_yrl.erl", "src/first_erl.erl"]}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix the first two entries by adding the src/
prefix.
Fix rebar.config.sample and some other place with incorect define erl_first_files. |
I think we should include a complete explanation for the regression in erlc_rt.erl. If I had to write it, I would add the following:
|
Fix commit message. |
Make more explanation of work with *_first_file. |
Thanks for including the extra comments. |
Need dialyzer check before merged! |
@roland-karlsson-erlang-solutions-com @lpgauth can you verify the fix works for you? |
It's clean with R16B03 Dialyzer, so if you get the same warnings with 17.x Dialyzer in rebar.git master, it's a different issue unrelated to this patch. Related: #263. |
The combination of changes to rebar_erlc_compiler, and the fact that erl_first_files is inherited, caused a regression. To fix that, ensure every project uses its own .rebar/erlcinfo. While at it, fix the issue that erl_first_files entries were not included when initializing the dep digraph. Reported-by: Louis-Philippe Gauthier Reported-by: Roland Karlsson Thanks: Tuncer Ayaz
Fix code formating. |
Sorry for not replying. Missed it. What fork and branch and commit am I supposed to test? |
|
It seems to work just fine!!!! The erl files are not being compiled in the deps and the MIB file is not copied to deps/*/ebin any more. Thank you! |
@jaredmorrow @ferd @tsloughter once this is reviewed and merged, we should make a new release. |
I was reviewing this and I saw that in most of the code snippets, changes of the form:
were taking place. Is this a change in what is supported? Is this backwards compatible? |
@ferd wrote:
The code snippet was wrong. For example, |
Sounds good to me. Going to merge this. Doing a sweep to see if anything else is ready to merge and then we can cut a release. |
Taking a note here to release rebar 2.3.2 on this, with all the merges from last week. Or might actually need to be 2.4.0 due to the eunit additions merged in last week? |
Yea, I think 2.4.0 is good. Need to get together a list of changes and a build on R14. |
Here are all the merged PR's since 2.3.1, I have a script that makes it easy.
|
Further notes:
|
The release is out, I haven't had the time to extend documentation, though. |
Repository that don't declare *_first_files was inherited it from parent. And
than try to compile some files that don't exists.
Issue #249