Skip to content
This repository has been archived by the owner on May 12, 2018. It is now read-only.

Namespaced types: fix build for 17.0 #292

Merged
merged 3 commits into from
Jun 11, 2014

Conversation

matwey
Copy link
Contributor

@matwey matwey commented May 31, 2014

No description provided.

@ghost
Copy link

ghost commented Jun 3, 2014

Thanks @matwey.

We need to define the same macro in the bootstrap escript, too. Also, we should add a comment in rebar.config and bootstrap explaining when (>= 17.x) and why (compiler warning) namespaced_types is defined. For future reference it'd be best to include a sample warning message in both comments.

That said, assuming we want to keep the type specs, this seems like a practical solution.

@ghost
Copy link

ghost commented Jun 6, 2014

Thanks for the fixes.

How about using a different comment?

Problem:
Beginning with Erlang 17.0 the compiler emits the following warning:
type dict/0 is deprecated and will be removed in OTP 18.0;
use use dict:dict/0 or preferably dict:dict/2
Solution:
When building on >= 17.x we define namespaced_types and use it as a
condition whether to fully qualify built-in types (dict:dict/0 vs dict/0).

The comment should also be included in both rebar.config and bootstrap where namespaced_types is defined.

@matwey
Copy link
Contributor Author

matwey commented Jun 11, 2014

I've added the comments.

tsloughter added a commit that referenced this pull request Jun 11, 2014
Namespaced types: fix build for 17.0
@tsloughter tsloughter merged commit 9080288 into rebar:master Jun 11, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants