Check C source dependencies in needs_compile

[liskin]

This makes rebar recompile/relink port drivers properly when only C headers change.

I tested this on Linux with gcc, I'm not sure whether this is portable.

[ghost]

Thanks @liskin.

We cannot use the binary module as the minimum Erlang/OTP version required by rebar is R13B03.

Same as you, I'm also not sure about MSVC compatibility (see rebar_port_compiler:default_env/0).

[liskin]

Oh, okay, I'll try to rewrite the parsing to use something else, although I wonder if there's an easy way to get such old Erlang. If you happen to know anything easier than lxc container and snapshot.debian.org, let me know. :-)

As I didn't modify the templates for win32, no .d files will be generated there and header deps will simply be ignored. That may or may not be considered a bug. :-)

[ghost]

@liskin wrote:

Oh, okay, I'll try to rewrite the parsing to use something else, although I wonder if there's an easy way to get such old Erlang. If you happen to know anything easier than lxc container and snapshot.debian.org, let me know. :-)

I can't suggest anything easier than that or switching between locally built versions in your shell environment.

As I didn't modify the templates for win32, no .d files will be generated there and header deps will simply be ignored. That may or may not be considered a bug. :-)

That sounds okay to me, but we may want to add a NOTE comment explaining that this is not supported with MSVC.

[tsloughter]

I'm going to be that guy again and propose dropping R13 support :)

[ghost]

@tsloughter wrote:

I'm going to be that guy again and propose dropping R13 support :)

The maintenance burden to support R13B03 is minimal, but the advantage is important. A rebar binary built with R13 or R14 works with any otp version from R13 up to 17. This helps ensure rebar to be a portable stand-alone binary.

[liskin]

So, there are some tests and a NOTE about win32 and I replaced binary:split with re:split, so it should work on R13, although I didn't manage to actually try. Why don't we have R13 builds in Travis?

[ferd]

@liskin regarding R13 and Travis, this is being covered in #295

[ghost]

This and the other comment lines should use %% instead.

[ghost]

We can fix the style issues in inttest/port/port_rt.erl in a follow-up patch. So, is there anything holding up a merge?

[ghost]

ping?

[tonyrog]

Wonderful!
Mega thanks for this fix :-)
This is good progress!