This repository has been archived by the owner on May 12, 2018. It is now read-only.
Fixed version of #395 #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix verbose level in global rebar config Replace application:set_env on erlang:put
ghost
mentioned this pull request
Closed
|
Tests fail. |
|
@ferd do you know why the relevant log label regex to match color codes doesn't make a difference (not matched)? If we cannot reliably match that, we might as well simplify the patterns and restore the original version. Tried with colored and uncolored rebar. |
* do not use pdict * do not enable color support by default. once we have the new getopt version, we can add a new type of command line flag for that. * fix Dialyzer warnings * use atom instead of boolean * use better name for internal function * do not try (and fail) to access rebar's app env in retest test
|
No idea. I remember trying the first time around when this branch was submitted and couldn't figure it out in the time I had to spend on the issue. |
|
Okay, let's merge it, then. |
|
Unless you want to simplify the patterns first. |
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getopt version, we can add a new type of command line flag
for that.