Travis dialyze

[ghost]

There are new Dialyzer errors. To not introduce any new warnings, try to enable Dialyzer on Travis-CI.

[ghost]

Finally figured out how to structure travis config and the results look good. One inttest CI timeout on 18 and as expected errors in the separate Dialyzer job. If we don't merge this, we will only accumulate more Dialyzer errors.

[ghost]

Waiting for #643 to be merged.

[ghost]

With the two silenced opaque match warnings, we're down to this (from https://travis-ci.org/rebar/rebar/jobs/266578662):

src/rebar_config.erl:103: Record construction
#config{dir::'undefined',
  opts::[any()],
  globals::dict:dict(_,_),
  envs::dict:dict(_,_),
  skip_dirs::dict:dict(_,_),
  xconf::dict:dict(_,_)}
violates the declared type of field dir::string()
src/rebar_core.erl:334: The call
rebar_config:new(ParentConfig::rebar_config:config()) contains an
opaque term as 1st argument when a structured term of type string() is
expected

I want to say when calling rebar_config:new, it should also set dir to CWD, but not sure.

---

src/rebar_erlc_compiler.erl:543: Function compile_mib/3 has no local return
src/rebar_erlc_compiler.erl:554: Record construction
#options{includes::[],
  outdir::[46,...],
  defines::[],
  warning::1,
  verbose::'false',
  optimize::999,
  specific::[],
  outfile::[],
  cwd::'undefined'}
violates the declared type of field cwd::string()
src/rebar_erlc_compiler.erl:556: Record construction
#options{includes::[],
  outdir::[46,...],
  defines::[],
  warning::1,
  verbose::'false',
  optimize::999,
  specific::[{'verbosity',_},...],
  outfile::[],
  cwd::'undefined'}
violates the declared type of field cwd::string()

Not sure. Maybe related to the rebar_config warning above?

---

src/rebar_xref.erl:261: The pattern {Source, 'function_not_found'} can
never match since previous clauses completely covered the type
{'module_not_found','function_not_found'}
src/rebar_xref.erl:262: The pattern {Source, Line} can never match
since previous clauses completely covered the type
{'module_not_found','function_not_found'}
src/rebar_xref.erl:268: Function safe_element/2 will never be called
src/rebar_xref.erl:287: Function find_function_source/4 has no local return

Tried to fix this, but couldn't figure it out.

[ghost]

@lrascao, maybe Dialyzer is more capable in 20.0 and has revealed issues that are quite old. I mean, that discrepancy in rebar_config looks risky to fix by overriding/initializing the dir with CWD. Any thoughts on whether we should instead try to silence the warning, or do you have an idea how to resolve it?

[lrascao]

The only idea i have is to use cwd, but as you say, it's probably not worth the risk, if there's a way to instead silence the warning that would be preferable

[ghost]

In order to get this merged and not get lost, we now allow the Dialyzer job to fail.