Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce shorthand properties #45

Closed
pke opened this issue Mar 10, 2016 · 2 comments
Closed

Introduce shorthand properties #45

pke opened this issue Mar 10, 2016 · 2 comments

Comments

@pke
Copy link

pke commented Mar 10, 2016

I really like the minimalist approach of this lib after ditching material-ui.

I have a proposal to make the components even more easier to read:

Given the current state

<Flex
  align="center"
  justify="space-between"
  wrap={true}
>

What do you think about:

<Flex center space-between wrap>

Would that make sense?

@pke
Copy link
Author

pke commented Mar 10, 2016

A sorry, mixed up the projects. That should go to http://jxnblk.com/reflexbox/

@pke pke closed this as completed Mar 10, 2016
@jxnblk
Copy link
Member

jxnblk commented Mar 10, 2016

Yeah I use shorthand booleans where appropriate (e.g. wrap). The docs are automatically generated from parsing jsx and it adds the true to props.

I tend to avoid booleans for potentially conflicting props like align and justify since they both have multiple possible values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants