Remove unused publish command #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfn
reviewed
Mar 16, 2023
There was a problem hiding this comment.
LGTM!
According to the git history, this was added years ago for Lumen. Lumen support was removed in #722 , but I guess I didn't realize this was specific to it. The only correct way to use artisans vendor:publish as documented in the readme 👍🏼
Can you do me a favour and apply it for the 8.x though, not master? Thanks!
sforward
force-pushed
the
chore/remove-publish-cmd
branch
from
d5acbc7
to
9180d7f
Compare
mfn
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The command wasn't registered anywhere, so I assume it's been replaced once but not removed.
Type of change:
Checklist:
composer fix-style