Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands improvements #1005

Merged
merged 4 commits into from
Mar 18, 2023
Merged

Commands improvements #1005

merged 4 commits into from
Mar 18, 2023

Conversation

sforward
Copy link
Contributor

Summary

Three improvements to the generator commands:

  • Register all commands at once, preventing extra method calls
  • Add AsCommand attribute to all commands, so they are not all instantiated on every artisan command execution
  • Add return types (breaking change)

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you please add a changelog entry for the breaking change?

Even if minor, who knows if someone extended one of those commands…

@sforward sforward requested a review from mfn March 18, 2023 06:15
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mfn mfn merged commit 20530a9 into rebing:master Mar 18, 2023
@sforward sforward deleted the feat/ascommand branch March 19, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants