Remove support for Laravel 8 (and PHP 7.4) #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfn
force-pushed
the
mfn-drop-l8
branch
3 times, most recently
from
bd5578a
to
b017310
Compare
mfn
commented
Jun 21, 2023
| "tests": "phpunit --colors=always --verbose" | ||
| "tests": "phpunit" |
There was a problem hiding this comment.
Actually removed this for phpunit compatibility, which I then abandoned to keep the scope of the PR from exploding, but nevertheless kept this changes.
| @@ -134,7 +134,7 @@ static function (array $result): array { | |||
| /** | |||
| * @return array<mixed> | |||
| */ | |||
| public function dataForEmptyQuery(): array | |||
| public static function dataForEmptyQuery(): array | |||
There was a problem hiding this comment.
Removes phpunit 10 warnings that dataproviders need to be static
| @@ -243,14 +242,6 @@ private function formatSafeTrace(array $trace): string | |||
| ); | |||
| } | |||
|
|
|||
| /** | |||
| * @todo Remove this method once we're PHPUnit 9+ only. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See title.
Reasoning: Laravel 8 as well as PHP 7.4 are long EOL and out of security support
Type of change:
Checklist:
composer fix-style