Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix schema validation - resolve not allowed in input fields #1078

Merged
merged 4 commits into from
Aug 6, 2023

Conversation

crissi
Copy link
Contributor

@crissi crissi commented Jul 24, 2023

Summary

I have some test code that validate the schemas correctness.
It gotten a bit stricter after the latest webonyx update and is complaining on this parameter:
GraphQL\Error\InvariantViolation: ExampleValidationInputObject.nullValue field has a resolve property, but Input Types cannot define resolvers.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@mfn mfn self-assigned this Aug 6, 2023
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

I simplified the test, updated the changelog and phpstan (which is a drive-by fix and not related to this PR).

@mfn mfn merged commit 106d060 into rebing:master Aug 6, 2023
19 checks passed
@mfn
Copy link
Collaborator

mfn commented Aug 6, 2023

Pushed 9.1.0 for this!

@crissi
Copy link
Contributor Author

crissi commented Aug 6, 2023

Thanks😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants