Forward PHP engine errors to the application error handler #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfn
force-pushed
the
mfn-engine-errors
branch
4 times, most recently
from
de0142b
to
6c096f8
Compare
|
FTR, I ran into this in a project I'm working on. There was a bug in the PHP code but because it was an engine error (it isn't in the |
mfn
force-pushed
the
mfn-engine-errors
branch
from
a79c97a
to
b957771
Compare
1 task
- 5.6: bug fixes ended on August 7th, 2018 and security fixes on February 7th, 2019 - 5.7: bug fixes ended on March 4th, 2019 and security fies on September 4th, 2019 Also: there's some weird edge case bug with 5.7 in the test \Rebing\GraphQL\Tests\Unit\SchemaHyphenInPathTest::testWithHyphen which makes it fail, see https://travis-ci.org/rebing/graphql-laravel/jobs/579289418 (this build was previously green until I restarted it recently): ``` 1) Rebing\GraphQL\Tests\Unit\SchemaHyphenInPathTest::testWithHyphen Failed asserting that exception of type "ErrorException" matches expected exception "Symfony\Component\HttpKernel\Exception\NotFoundHttpException". Message was: "Invalid argument supplied for foreach()" at /home/travis/build/rebing/graphql-laravel/vendor/laravel/framework/src/Illuminate/Foundation/Testing/TestResponse.php:739 /home/travis/build/rebing/graphql-laravel/vendor/laravel/framework/src/Illuminate/Foundation/Testing/TestResponse.php:718 /home/travis/build/rebing/graphql-laravel/vendor/laravel/framework/src/Illuminate/Foundation/Testing/TestResponse.php:690 /home/travis/build/rebing/graphql-laravel/vendor/laravel/framework/src/Illuminate/Foundation/Testing/TestResponse.php:756 /home/travis/build/rebing/graphql-laravel/tests/Unit/SchemaHyphenInPathTest.php:29 ``` Locally everything is working fine so I don't see a reason to pursue this further.
Using a "real PHP error" would always trigger PHPStan to actually report it and this abort the travis testing pipeline.
mfn
force-pushed
the
mfn-engine-errors
branch
from
b957771
to
07147f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise PHP errors, like
TypeErrorhappening (as part of bugs 🤷♀️) inside PHP code executed in GraphQL queries are not reported via the application error handler.Only a regular "internal error" was returned but the actual error was nowhere found in the logs or 3rd party error handling services.
TODO
Note
This is a change in behaviour of the library and thus subject to semver requiring a major version bump (as established in #481 (comment) ). I.e. the next release has to be
3after this is merged.