Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add morph type to returned models #503

Merged
merged 3 commits into from
Nov 5, 2019
Merged

Conversation

crissi
Copy link
Contributor

@crissi crissi commented Oct 25, 2019

when you retrieve the morphed models in your query resolver the type is missing so don't know what type it is

Are we going to continue to support 5.5? can see the tests are failing for that version

@crissi crissi force-pushed the morph_with_type branch 2 times, most recently from af79f3a to bd00c42 Compare October 25, 2019 09:25
@mfn
Copy link
Collaborator

mfn commented Oct 25, 2019

Are we going to continue to support 5.5? can see the tests are failing for that version

Thanks for asking, I haven't yet disclosed my thoughts on this.

Basically I'm following https://laravel.com/docs/master/releases
image

That's why I also removed tests for 5.6 and 5.7 without much discussion via #488

I basically took the easy way out: I just stick to the LTS table. Once a version is beyond security fixes it can be removed on first sign of troubles.

@crissi
Copy link
Contributor Author

crissi commented Oct 25, 2019

Are we going to continue to support 5.5? can see the tests are failing for that version

Thanks for asking, I haven't yet disclosed my thoughts on this.

Basically I'm following https://laravel.com/docs/master/releases
image

That's why I also removed tests for 5.6 and 5.7 without much discussion via #488

I basically took the easy way out: I just stick to the LTS table. Once a version is beyond security fixes it can be removed on first sign of troubles.

Ok will make a fix for laravel 5.5

@crissi
Copy link
Contributor Author

crissi commented Oct 28, 2019

how do I actually run this for Laravel 5.5 locally? I tried removing all other versions from illuminate/contracts, illuminate/support in the composer.json, but gets alot of composer errors.

@mfn
Copy link
Collaborator

mfn commented Oct 28, 2019

I believe from .travis.yml, these lines from the install section are relevant:

composer require "illuminate/support:${LARAVEL}" --no-interaction --no-update
composer install --prefer-dist --no-interaction --no-suggest

@crissi
Copy link
Contributor Author

crissi commented Oct 28, 2019 via email

src/Support/SelectFields.php Outdated Show resolved Hide resolved
src/Support/SelectFields.php Outdated Show resolved Hide resolved
@crissi crissi force-pushed the morph_with_type branch 2 times, most recently from de290e2 to 3cf3c8d Compare November 4, 2019 09:00
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much 🤗

@mfn mfn merged commit bea70b5 into rebing:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants