more control over validation through optional user-generated validator #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some code styling errors in the file i changed which have been there before my modification. Should i change them or ignore them as they have not been introduced by my change? |
Not sure what you mean, didn't see anything. I mean if you're talking about StyleCI: we replaced it with php-cs fixer, we just weren't able to remove the integration yet. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
My issues #505, #506 and #507 indicated that the actual validation implementation is not customizable enough for some cases. @mfn had the idea in #506 to add a
getValidatormethod to implement the functionality. I did the needed minimal changes and verified that all 3 issues can be solved by this small code change.Type of change
Checklist
composer fix-tyle