Fix interface fields selection #607
Conversation
illambo
changed the title
|
@crissi what do you think about this? Looks "sane" to me, but 🤷♀️ |
|
Does the sql alias still work? The test does not seem to cover the bug, I only see changes to the sql |
|
I try to elaborate a targeted test if needs. |
|
Of course it would be better if the missing foreign key was added instead of *, but that might be difficult |
|
I agree @crissi but I don't have time now to go further, is an acceptable solution for you now? |
|
Would this also fix #491 ? Would be a brief summary of how we fixed it? Would the following be an accurate description?
? thanks |
|
Yes, I think also fix that, but the unit test actually don’t cover this case (maybe later I can try to add that if needs). |
There was a problem hiding this comment.
Alright!
Thanks @crissi
@illambo please also add a changelog entry ; I tried to do it myself but pushing to your branch wasn't allowed, something like this please:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3f51e77..2c829b0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ CHANGELOG
- Add support for macros on the GraphQL service/facade [\#592 / stevelacey](https://github.com/rebing/graphql-laravel/pull/592)
### Fixed
- Fix the infinite loop as well as sending the correct matching input data to the rule-callback [\#579 / crissi](https://github.com/rebing/graphql-laravel/pull/579)
+- Fix selecting not the correct columns for interface fields [\#607 / illambo](https://github.com/rebing/graphql-laravel/pull/607)
### Changed
- Refactor route files with the goal of making adding subscription support easier [\#575 / crissi](https://github.com/rebing/graphql-laravel/pull/575)
### Removedthanks!
|
@mfn ok, done |
|
https://github.com/rebing/graphql-laravel/releases/tag/5.0.0 has been released which includes this! |
Summary
Fix interface fields selection.
Type of change
Checklist
Links
Resolve #605
Resolve #491