Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL::type modifier support #621

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

stevelacey
Copy link
Contributor

@stevelacey stevelacey commented Apr 6, 2020

Summary

Adds support for type modifiers and standard types to GraphQL::type.

GraphQL::type('MyInput!');
GraphQL::type('[MyInput]');
GraphQL::type('[MyInput]!');
GraphQL::type('[MyInput!]!');

GraphQL::type('String');
GraphQL::type('String!');
GraphQL::type('[String]');
GraphQL::type('[String]!');
GraphQL::type('[String!]!');

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@stevelacey stevelacey force-pushed the graphql-type-modifier-support branch 5 times, most recently from c07d4e7 to a28a2f3 Compare April 6, 2020 10:38
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, your further comments and the tests changed my mind!

src/GraphQL.php Outdated Show resolved Hide resolved
@mfn mfn force-pushed the graphql-type-modifier-support branch from a28a2f3 to 10fca17 Compare April 6, 2020 18:20
@mfn mfn merged commit 563b3e8 into rebing:master Apr 6, 2020
@mfn mfn mentioned this pull request Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants