Upgrade graphiql to v2 #978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfn
requested changes
Feb 7, 2023
There was a problem hiding this comment.
Hey, thanks for the PR!
- where is the source for these changes?
- you dropped the xcsrf token, i.e. this commit -> 3942314
- also see inline feedback
The tests are not working but before fixing them, we should have consent that the changes are good.
Comment on lines
+38
to
+39
| <script src="https://cdn.jsdelivr.net/npm/react/umd/react.production.min.js"></script> | ||
| <script src="https://cdn.jsdelivr.net/npm/react-dom/umd/react-dom.production.min.js"></script> |
There was a problem hiding this comment.
This looks risky, because it has no pinned versions. Is this deliberate?
|
I'm closing this PR as it's my intention to actually remove it, see #986 (reduce complexity, reduce maintenance burden), because I think with https://github.com/mll-lab/laravel-graphiql there's better / viable alternative. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade graphiql client to v2.3
Type of change:
Checklist:
composer fix-style