Fix bitcoin#367

rebroad · Jun 28, 2021 · 346d77c · 346d77c
1 parent cf8d469
commit 346d77c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 27 deletions.
diff --git a/src/qt/peertablemodel.cpp b/src/qt/peertablemodel.cpp
@@ -159,30 +159,7 @@ void PeerTableModel::refresh()
         new_peers_data.append(stats);
     }
 
-    // Handle peer addition or removal as suggested in Qt Docs. See:
-    // - https://doc.qt.io/qt-5/model-view-programming.html#inserting-and-removing-rows
-    // - https://doc.qt.io/qt-5/model-view-programming.html#resizable-models
-    // We take advantage of the fact that the std::vector returned
-    // by interfaces::Node::getNodesStats is sorted by nodeid.
-    for (int i = 0; i < m_peers_data.size();) {
-        if (i < new_peers_data.size() && m_peers_data.at(i).nodeStats.nodeid == new_peers_data.at(i).nodeStats.nodeid) {
-            ++i;
-            continue;
-        }
-        // A peer has been removed from the table.
-        beginRemoveRows(QModelIndex(), i, i);
-        m_peers_data.erase(m_peers_data.begin() + i);
-        endRemoveRows();
-    }
-
-    if (m_peers_data.size() < new_peers_data.size()) {
-        // Some peers have been added to the end of the table.
-        beginInsertRows(QModelIndex(), m_peers_data.size(), new_peers_data.size() - 1);
-        m_peers_data.swap(new_peers_data);
-        endInsertRows();
-    } else {
-        m_peers_data.swap(new_peers_data);
-    }
-
-    Q_EMIT changed();
+    Q_EMIT layoutAboutToBeChanged();
+    m_peers_data.swap(new_peers_data);
+    Q_EMIT layoutChanged();
 }
diff --git a/src/qt/rpcconsole.cpp b/src/qt/rpcconsole.cpp
@@ -685,7 +685,7 @@ void RPCConsole::setClientModel(ClientModel *model, int bestblock_height, int64_
 
         // peer table signal handling - update peer details when selecting new node
         connect(ui->peerWidget->selectionModel(), &QItemSelectionModel::selectionChanged, this, &RPCConsole::updateDetailWidget);
-        connect(model->getPeerTableModel(), &PeerTableModel::changed, this, &RPCConsole::updateDetailWidget);
+        connect(model->getPeerTableModel(), &PeerTableModel::layoutChanged, this, &RPCConsole::updateDetailWidget);
 
         // set up ban table
         ui->banlistWidget->setModel(model->getBanTableModel());