Add flag to disable alias requirement #983
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The requirement for an alias is arbitrary. There are many use cases where an alias is not able to be added to an account, or is pointless to do so. An example where it is a pointless requirement is when creating transient AWS sandbox accounts for development use, which must be destroyed.
The MIT license which this library is offered under, states that the library is offered as-is, with no warranties.
This PR adds a feature flag which can be added to the
config.yaml(delete-accounts-without-alias) which skips the checks for an alias when deleting accounts.For anyone who wishes to use this feature flag for testing, you can install the fork by cloning github.com/stefanmcshane/aws-nuke, checking out
disable-aliasand runninggo installFixes #971