define env vars with double quotes, and escaping the values

rebx · Nov 5, 2009 · ff4a873 · ff4a873
1 parent 353e632
commit ff4a873
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/rush/box.rb b/lib/rush/box.rb
@@ -80,7 +80,7 @@ def command_with_environment(command, env)   # :nodoc:
 		return command unless env
 
 		vars = env.map do |key, value|
-			"export #{key}='#{value}'"
+			"export #{key}=\"#{value.gsub('"', '\\"')}\""
 		end
 		vars.push(command).join("\n")
 	end

diff --git a/spec/box_spec.rb b/spec/box_spec.rb
@@ -38,7 +38,11 @@
 	end
 
 	it "builds a script of environment variables to prefix the bash command" do
-		@box.command_with_environment('cmd', { :a => 'b' }).should == "export a='b'\ncmd"
+		@box.command_with_environment('cmd', { :a => 'b' }).should == "export a=\"b\"\ncmd"
+	end
+
+	it "escapes quotes on environment variables" do
+		@box.command_with_environment('cmd', { :a => 'a"b' }).should == "export a=\"a\\\"b\"\ncmd"
 	end
 
 	it "sets the environment variables from the provided hash" do