fix:rcBuildLayerRegions missing areaType #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppiastucki
added a commit
to recast4j/recast4j
that referenced
this pull request
Mar 23, 2021
ppiastucki
added a commit
to recast4j/recast4j
that referenced
this pull request
Mar 23, 2021
ppiastucki
added a commit
to recast4j/recast4j
that referenced
this pull request
Mar 23, 2021
|
This fix is absolutely vital to get area IDs working correctly. Here is what happens without it:
The black blocks use a different area ID and should show up in red rather than blue. As you can see, the blue area ID takes over in many places. The dark blue grid lines are tile borders, so that's why the area ID is correct for half the black block, but not the other half, because a tile border separates them. With the fix, the area IDs work as expected:
It would be great, if this PR could be merged to the main branch. |
zlonglin
pushed a commit
to zlonglin/recastnavigation
that referenced
this pull request
Feb 1, 2024
Co-authored-by: sunming <359944951@qq.com> Co-authored-by: Graham Pentheny <grahamboree@users.noreply.github.com> (cherry picked from commit ddaa361)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix:rcBuildLayerRegions missing areaType