Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of double-with and double-heigh text in html. #15

Merged
merged 1 commit into from
May 21, 2017

Conversation

mike42
Copy link
Contributor

@mike42 mike42 commented May 21, 2017

This pull request implements double-height and double-width text at a line-level. This is triggered by SelectPrintModeCmd or SelectCharacterSizeCmd. 1x1, 1x2, 2x1 and 2x2 are all supported, with higher multiples capped for some compatibility (eg attempting 4x width will cause 2x width to be used).

Some unrelated bug fixes are also included-

  • 2D data code parsing caused a 'class not found' due to a typo
  • Emphasis was not applied to SelectPrintModeCmd.

Switching the values mid-line does work, but the character alignment (width and height) is quite buggy.

  • Multiple heights should go to baseline
  • Multiple widths should not overlap

This will require a lot of re-work to display perfectly, and is not as important as some other missing features, so I'm submitting this as-is.

Example from #8-

screenshot from 2017-05-21 12-51-36

Larger example showing heights for #12, outstanding rendering issues-

screenshot from 2017-05-21 12-57-19

Reference-

@mike42 mike42 changed the title Initial implementation of double-with and double-heigh text in html. … Initial implementation of double-with and double-heigh text in html. May 21, 2017
@mike42 mike42 merged commit 25be593 into master May 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant